Skip to content

ref: Dependency container in Swift #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2025
Merged

ref: Dependency container in Swift #6444

merged 3 commits into from
Oct 21, 2025
+584 −723

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 17, 2025 •
edited
Loading

Wraps up the Swift migration by making the dependency container in Swift.

There are a huge number of files that #import "SentryDependencyContainer.h" So to make this PR easier to review I've left that file there, just empty, and will remove it in a follow up PR.

#skip-changelog

@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.48201% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.002%. Comparing base (abafa5d) to head (dcf57ca).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryANRStoppedResultInternal.m 75.000% 1 Missing and 1 partial ⚠️
...tions/SentryWatchdogTerminationScopeObserver.swift 83.333% 2 Missing ⚠️
Sources/Swift/SentryDependencyContainer.swift 98.857% 2 Missing ⚠️
...Swift/Core/Integrations/ANR/SentryANRTracker.swift 97.368% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6444       +/-   ##
=============================================
+ Coverage   86.933%   87.002%   +0.068%     
=============================================
  Files          452       453        +1     
  Lines        37760     37760               
  Branches     17475     17506       +31     
=============================================
+ Hits         32826     32852       +26     
+ Misses        4890      4863       -27     
- Partials        44        45        +1
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackerV1.m 93.893% <100.000%> (ø)
Sources/Sentry/SentryANRTrackerV2.m 98.895% <100.000%> (+4.419%) ⬆️
Sources/Sentry/SentryDebugImageProviderInternal.m 80.952% <100.000%> (-0.225%) ⬇️
Sources/Sentry/SentryDelayedFramesTracker.m 96.815% <100.000%> (+3.526%) ⬆️
Sources/Sentry/SentrySpan.m 97.718% <100.000%> (ø)
Sources/Sentry/SentryTracer.m 97.549% <100.000%> (-0.164%) ⬇️
...tions/FramesTracking/SentryFramesDelayResult.swift 100.000% <100.000%> (ø)
...egrations/FramesTracking/SentryFramesTracker.swift 100.000% <100.000%> (ø)
Sources/Swift/Helper/Dependencies.swift 100.000% <ø> (ø)
...Swift/Core/Integrations/ANR/SentryANRTracker.swift 97.872% <97.368%> (-2.128%) ⬇️
... and 3 more

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abafa5d...dcf57ca. Read the comment docs.

@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch 14 times, most recently from 9d7cbdb to 63ac42f Compare October 20, 2025 18:20
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.17 ms 1255.81 ms 23.64 ms
Size 23.74 KiB 1.01 MiB 1009.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4b3f1af 1227.04 ms 1253.35 ms 26.31 ms
5218a05 1236.35 ms 1245.41 ms 9.06 ms
c3fece5 1240.65 ms 1260.75 ms 20.10 ms
99104c9 1224.84 ms 1247.08 ms 22.24 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
93c76b0 1236.92 ms 1265.82 ms 28.90 ms
480185d 1220.50 ms 1246.04 ms 25.54 ms
aac24ac 1225.94 ms 1256.38 ms 30.45 ms
8bb3e37 1237.15 ms 1258.33 ms 21.19 ms
3ec47ae 1229.71 ms 1257.13 ms 27.41 ms

App size

Revision Plain With Sentry Diff
4b3f1af 23.75 KiB 981.30 KiB 957.56 KiB
5218a05 23.75 KiB 984.71 KiB 960.96 KiB
c3fece5 23.75 KiB 874.17 KiB 850.42 KiB
99104c9 23.75 KiB 894.83 KiB 871.09 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
93c76b0 23.75 KiB 946.69 KiB 922.95 KiB
480185d 23.75 KiB 913.42 KiB 889.67 KiB
aac24ac 23.75 KiB 1019.17 KiB 995.42 KiB
8bb3e37 23.75 KiB 968.16 KiB 944.41 KiB
3ec47ae 23.75 KiB 919.91 KiB 896.16 KiB

Previous results on branch: dependencyContainerSwift

Startup times

Revision Plain With Sentry Diff
f4e8ecd 1234.63 ms 1265.00 ms 30.37 ms
ca52141 1236.00 ms 1270.52 ms 34.52 ms
7983312 1232.29 ms 1256.06 ms 23.77 ms
2cca378 1231.40 ms 1256.67 ms 25.26 ms
7e87ca2 1213.90 ms 1248.96 ms 35.06 ms
e4f30fd 1223.00 ms 1265.11 ms 42.11 ms
02a7e1f 1226.27 ms 1260.26 ms 33.99 ms
1efc2cc 1237.15 ms 1271.24 ms 34.09 ms

App size

Revision Plain With Sentry Diff
f4e8ecd 23.74 KiB 1.01 MiB 1009.23 KiB
ca52141 23.74 KiB 1.01 MiB 1007.46 KiB
7983312 23.74 KiB 1.01 MiB 1009.11 KiB
2cca378 23.75 KiB 1.00 MiB 1004.86 KiB
7e87ca2 23.74 KiB 1.01 MiB 1008.52 KiB
e4f30fd 23.74 KiB 1.00 MiB 1005.70 KiB
02a7e1f 23.74 KiB 1.01 MiB 1009.22 KiB
1efc2cc 23.74 KiB 1.01 MiB 1007.12 KiB

@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch from 63ac42f to da7ca39 Compare October 20, 2025 18:54
@itaybre itaybre self-requested a review October 20, 2025 20:57
@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch 11 times, most recently from 4e8ed72 to 26a0f4d Compare October 21, 2025 15:03
@noahsmartin noahsmartin marked this pull request as ready for review October 21, 2025 15:08
cursor[bot]

This comment was marked as outdated.

Sign in to view

@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch 2 times, most recently from 0c12cfe to d079da3 Compare October 21, 2025 15:29
@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch from d079da3 to 9ab435f Compare October 21, 2025 16:15
cursor[bot]

This comment was marked as outdated.

Sign in to view

@noahsmartin noahsmartin merged commit 0bef3a6 into main Oct 21, 2025
179 checks passed
@noahsmartin noahsmartin deleted the dependencyContainerSwift branch October 21, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itaybre itaybre itaybre approved these changes

@cursor cursor[bot] cursor[bot] left review comments

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noahsmartin @itaybre